On 01/19/2010 03:24 PM, Matthias Bolte wrote:
2010/1/19 Laine Stump<laine@laine.org>:
On 01/13/2010 12:09 PM, Laine Stump wrote:
It's been 12 days with no responses to these patches, so I figured I'd better give them some visibility so they're not forgotten.
https://www.redhat.com/archives/libvir-list/2010-January/msg00003.html
Dan was kind enough to review and ACK these. Now if someone could just push them... ;-)
Okay. pushed :)
Thanks!
I had to apply this small patch to fix a compile error:
diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index 6efc8aa..8a17ed6 100644 --- a/src/conf/interface_conf.c +++ b/src/conf/interface_conf.c @@ -705,7 +705,8 @@ virInterfaceDefParseXML(virConnectPtr conn, || (parentIfType == VIR_INTERFACE_TYPE_VLAN)) { virInterfaceReportError(conn, VIR_ERR_XML_ERROR, - _("interface has unsupported type '%s'"), type); + _("interface has unsupported type '%s'"), + virInterfaceTypeToString(type)); goto error; } def->type = type;
This is troublesome - I'm glad you caught it. The code was so obviously wrong, and yet when I build with it (just tried it again to be sure), I don't even get a warning (I tried turning on -Werror and the whole process aborts much earlier with warnings in some other file). What CFLAGS are you giving to configure? Here's what I have: CFLAGS="-g -Wformat -Wformat-security -Winit-self -Wall -Wpointer-arith -Wextra -Wshadow -Wcast-align -Wwrite-strings -Winline -Wno-sign-compare -Wp,-D_FORTIFY_SOURCE=2 -Dlint"