Re: [PATCH 5/8] wireshark: Don't special case retval of get_program_data() in dissect_libvirt_message()

On Tue, Oct 14, 2025 at 08:31:44 +0200, Michal Privoznik via Devel wrote:

From: Michal Privoznik <mprivozn@redhat.com>

The get_program_data() function returns a pointer (in this specific case to an array of procedure strings) which, if non-NULL is then passed val_to_str(). Well, if val_to_str() sees NULL it is treated gracefully, i.e. like if the numeric value 'proc' wasn't found in the array.

Therefore, there's no need to special case call to col_append_fstr(). Both result into the same behaviour.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- tools/wireshark/src/packet-libvirt.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>