On 01/06/2014 03:18 AM, Michal Privoznik wrote:
+ + if (initctlRequested || !flags) + useInitctl = true;
I'm not sure this logic is right.
Yuck - commit aa4619337 is broken.
This is still unfortunately the case in what you pushed. And how come you didn't do the same treatment to lxcDomainReboot, which also has two different flags where we need proper fallback when initctl is unsupported? Your commit conflicts with the pending CVE-2013-6456 efforts (my patch at [1]), so we need to get this resolved.
[1] https://www.redhat.com/archives/libvir-list/2013-December/msg01249.html
Yep, I've pushed it accidentally. I've merged a branch which wasn't rebased onto master but onto a different local brach containing this commit. I suggest reverting my commit. I'll post better version (with lxcDomainReboot) then. Sorry for the noise.
No problems; we still have time to get it right before the release. For now, I've pushed the revert patch. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org