Re: [PATCH 1/3] qemuBackupPrepare: Actually allow 'VIR_STORAGE_NET_HOST_TRANS_FD'
On Mon, May 19, 2025 at 18:37:03 +0200, Ján Tomko wrote:
On a Monday in 2025, Peter Krempa via Devel wrote:
> From: Peter Krempa <pkrempa(a)redhat.com>
>
> While I've actually implemented support for FD passing the NBD server
> socket in eb768a556db I managed to misplace the hunk allowing the 'FD'
> transport in the validation code, rendering the whole feature useless.
>
> Fix the validation logic to make the feature useful.
s/useful/usable/?
>
> Fixes: eb768a556db75040f7b518d198a18bd0f5d6faad
The commit that misplaced the case is:
commit ee49106dbf6f3c716f0e31c9ecc9bf528eb72bb2
conf: Introduce VIR_STORAGE_NET_HOST_TRANS_FD
Not the one you mention (twice).
That commit placed it correctly (at that point in time) because the
implementation wasn't there. The commit I'm mentioning was supposed to
allow it (I mentioned "misplacing hunk allowing the 'FD' transport').
> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
> ---
> src/qemu/qemu_backup.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano