Re: [libvirt] [PATCH v5 2/9] libxl: pass driver config to libxlMakeDomBuildInfo

On Wed, Mar 14, 2018 at 03:26:09AM +0100, Marek Marczykowski-Górecki wrote: > @@ -48,6 +49,19 @@ VIR_MOCK_IMPL_RET_ARGS(xc_interface_open, > } > > > +VIR_MOCK_IMPL_RET_ARGS(libxl_get_version_info, > + const libxl_version_info*, > + libxl_ctx *, ctx) > +{ > + static libxl_version_info info; > + > + memset(&info, 0, sizeof(info)); > + > + return &info; > + /* silence gcc warning */ > + return real_libxl_get_version_info(ctx); Why was gcc warning about that requires the second return statement ? I would have though this would /cause/ a warning by creating unreachable code ?