Re: [libvirt] [PATCH] Support for virtualbox version 3.1

2009/11/20 pritesh <Pritesh.Kothari(a)sun.com&gt;: > Hi All, > >> > ACK, apart from the minor issues in vboxGenerateMediumName() and >> > vboxGetDeviceDetails(). >> > >> > Matthias >> >> once again thanks for review, will try to split the patch in two and repost >>  it again which changes suggested above, but before that, would like to >>  know if esxVMX_IndexToDiskName() goes into util.[ch] anytime soon or only >>  after the release? >> > > Just fixed all the above mentioned bugs/quirks and also fixed serial port > configuration which was broken due to recent change in virDomainChrDef where > targetType was newly added. > > The patch applies on the current big hunk sent before. > > Regards, > Pritesh > I found a small issue with virDiskNameToIndex() while moving esxVMX_IndexToDiskName() to util.c that affects your vboxGenerateMediumName() too. virDiskNameToIndex() created adjacent indices up to 701. 701 maps to sdzz and sdaaa maps to 728. The indices in between have no disk name representation. Because of this your inverse mapping in vboxGenerateMediumName() will fail for indices > 701, but this can be solved once we have a general virIndexToDiskName() in util.c. I've posted patches to move esxVMX_IndexToDiskName() to util.c and to solve the gap problem or to handle it at least. ACK to your 2nd patch. Matthias