[libvirt] BSD remote_protocol [was: [PATCH] build: mark conditionally unused variables]

On 05/02/2013 06:38 AM, Roman Bogorodskiy wrote: CC libvirt_driver_remote_la-remote_protocol.lo cc1: warnings being treated as errors ./remote/remote_protocol.c: In function 'xdr_remote_node_get_cpu_stats_ret': ./remote/remote_protocol.c:530: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] I suspect this is a macro expansion triggering the actual warning; can you determine what the preprocessed text is that is behind this warning? I bet we can fix it in one or two places for all of the warnings triggered on this file. node_device/node_device_driver.c: In function 'update_caps': node_device/node_device_driver.c:51: warning: statement with no effect That comes from: detect_scsi_host_caps(&dev->def->caps->data); which in turn shows up as this in node_device_driver.h: # define detect_scsi_host_caps(d) (-1) I don't know why I'm not seeing the warning, but that one's easy to fix - I can try to patch that one. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org