Re: [libvirt] [PATCH] Use virNetServerClientImmediateClose() rather than virNetServerClientClose()

Monday, 25 November 2019


On Mon, Nov 25, 2019 at 07:23:07PM +0800, LanceLiu wrote:

Please include a description why this change is needed in the commit
message, to give the people looking at the git history some
understanding of it without having to go through the mailing list
archives.

See the following blog post for some commit message guidelines:
https://www.berrange.com/posts/2012/06/27/thoughts-on-improving-openstack...

...
---
 src/remote/remote_daemon_stream.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
 
...
@@ -262,7 +262,7 @@ daemonStreamEvent(virStreamPtr st, int events,
void *opaque)
         }
         daemonRemoveClientStream(client, stream);
         if (ret < 0)
-            virNetServerClientClose(client);
+        	virNetServerClientImmediateClose(client); 
Looks like the indentation is off here.

Jano

...
         goto cleanup;
     }

-- 
1.8.3.1


--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list 
    