Re: [libvirt] [jenkins-ci PATCH v2] lcitool: check for virt-install / ansible-playbook in $PATH
On Fri, 2019-05-03 at 11:02 +0100, Daniel P. Berrangé wrote:
This improves error reporting:
$ ./lcitool install libvirt-fedora-29
./lcitool: Failed to install 'libvirt-fedora-29': [Errno 2] No such file or
directory
To
$ ./lcitool install libvirt-fedora-29
./lcitool: Cannot find virt-install in $PATH
Much nicer indeed!
@@ -461,8 +462,12 @@ class Application:
"git_branch": git_branch,
})
+ ap_path = distutils.spawn.find_executable("ansible-playbook")
Please call this 'ansible_playbook' instead of 'ap_path'...
@@ -534,8 +539,12 @@ class Application:
# a kernel argument
extra_arg = "console=ttyS0 ks=file:/{}".format(install_config)
+ vi_path = distutils.spawn.find_executable("virt-install")
... and same here.
Other than that, this works and AFAICT addresses all issues Pino
raised for v1, so
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization