Re: [libvirt] [PATCH 08/14] virsh-completer: use VIR_AUTOSTRINGLIST for tmp
On Wed, Apr 03, 2019 at 09:55:33AM +0200, Peter Krempa wrote:
On Mon, Apr 01, 2019 at 09:33:25 +0200, Ján Tomko wrote:
> Now that every function uses virStringListFree, we can use the
> VIR_AUTOSTRINGLIST to have the compiler call this function automatically
> when 'tmp' goes out of scope.
Again something that could be done in previous patch directly. You are
adding a bunch of calls to virStringListFree which vanish here.
ACK but really consider squashing this one.
Squashed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
Attachments:
- signature.asc (application/pgp-signature — 488 bytes)