Re: [libvirt] [PATCH 5/5] qemu_process: graphics: setup listen types before ports are reserved/allocated
On 08/15/2016 07:28 AM, Pavel Hrdina wrote:
Similar to 4/5 a few extra words here would help so one doesn't have to
chase into the bz to attempt to figure out what's being fixed and why
moving the Setup earlier does what you want.
ACK series - please do add a few more commit words though
John
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
---
src/qemu/qemu_process.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index b3c6400..2b857bb 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -4213,6 +4213,13 @@ qemuProcessSetupGraphics(virQEMUDriverPtr driver,
size_t i;
int ret = -1;
+ for (i = 0; i < vm->def->ngraphics; i++) {
+ graphics = vm->def->graphics[i];
+
+ if (qemuProcessGraphicsSetupListen(driver, graphics, vm) < 0)
+ goto cleanup;
+ }
+
if (allocate) {
for (i = 0; i < vm->def->ngraphics; i++) {
graphics = vm->def->graphics[i];
@@ -4227,9 +4234,6 @@ qemuProcessSetupGraphics(virQEMUDriverPtr driver,
if (qemuProcessGraphicsAllocatePorts(driver, graphics, allocate) < 0)
goto cleanup;
-
- if (qemuProcessGraphicsSetupListen(driver, graphics, vm) < 0)
- goto cleanup;
}
ret = 0;