Re: [libvirt] [PATCH] tests: Add URI precedence checking

Commit a0b6a36f is fixing what commit abfff210 broke, so to avoid having to deal with this issue again, I present you The "uriprecedencetest". Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; --- tests/Makefile.am | 2 ++ tests/uriprecedencetest | 77 +++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 79 insertions(+) create mode 100755 tests/uriprecedencetest diff --git a/tests/Makefile.am b/tests/Makefile.am index 09144d6..419db8b 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -98,6 +98,7 @@ EXTRA_DIST = \ storagevolxml2xmlout \ sysinfodata \ test-lib.sh \ + uriprecedencetest \ vmx2xmldata \ xencapsdata \ xmconfigdata \ @@ -235,6 +236,7 @@ test_scripts += \ read-bufsiz \ read-non-seekable \ start \ + uriprecedencetest \

vcpupin \ virsh-all \ virsh-optparse \ diff --git a/tests/uriprecedencetest b/tests/uriprecedencetest new file mode 100755 index 0000000..9515e63 --- /dev/null +++ b/tests/uriprecedencetest @@ -0,0 +1,77 @@ +#!/bin/sh + +: ${srcdir=.} +. $srcdir/test-lib.sh + +# This test checks if virsh obeys the proper precedence of different +# URI settings +test_intro "uriprecedencetest" + +virsh_bin="$abs_top_builddir/tools/virsh" +counter=1 +ret=0 + +tmpdir="$(mktemp -d)" +cleanup_() { rm -rf "$tmpdir"; }

+unset LIBVIRT_DEFAULT_URI +unset VIRSH_DEFAULT_CONNECT_URI +bad_uri="test:///default?bad_uri" +good_uri="test:///default?good_uri"