Re: [libvirt] [PATCH 02/12] Introduce new domain create API virDomainCreateWithParams
On Wed, May 09, 2018 at 04:56:12PM +0200, Marc Hartmayer wrote:
Introduce new libvirt API virDomainCreateWithParams that allows to
temporarily boot from another boot device, to use another kernel,
initrd, and cmdline than defined in the persistent domain
definition. All typed parameters are optional.
The design of the API was chosen to ease future extensions.
I don't really see the point in doing this. We already have the ability
to temporary boot with a different configuration than is stored in
the persistent XML. Just call virDomainCreateXML() passing in the
alternative XML doc. This allows changing *any* aspect of the guest
configuration, so we're not restricted to just bot device, kernel
initrd and cmdline, and thus won't need to write more code anytime
someone asks to be able to override something else too.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|