On Tue, May 25, 2021 at 05:06:41PM +0200, Michal Prívozník wrote:
On 5/25/21 12:00 PM, Andrea Bolognani wrote:
On Tue, May 25, 2021 at 10:00:47AM +0200, Pavel Hrdina wrote:
-# For storage wiping with different algorithms -BuildRequires: scrub
Turns out we're actually missing the runtime dependency on scrub! Can you please take care of addressing that issue in a separate patch?
Are we? scrub is needed if and only if you want to pass a special algorithm to virStorageVolWipePattern(). Does that justify a runtime dependency? We fail gracefully if scrub isn't installed. We aren't even requiring qemu binary for daemon-driver-qemu package.
Wasn't the whole idea to drop dependencies?
The point was to drop **build** dependencies, specifically problematic ones such as ZFS. When it comes to runtime dependencies, our RPMs generally try to be as featureful as possible, so adding a dependency on scrub is the right thing to do IMO. -- Andrea Bolognani / Red Hat / Virtualization