Re: [libvirt] [PATCH 1/2] Add VSCSI bus type and VSCSI controller type for pseries guest.

On 05/04/2012 02:45 PM, Osier Yang wrote: > >On 2012年05月04日 10:05, Li Zhang wrote: >>Now, there is only SCSI bus and controller type in libvirt. >>And when configuring VSCSI controller, it needs to configure >>the spapr-vio bus address type externally. It's a little >>inconvenient to configure the controller type. > >Not sure if I understood correctly, but we have a scsi controller >model type 'ibmvscsi'. Isn't it enough to tell the difference? I think it's not enough. >And 'ibmvsci' is choosed as the default scsi controller model if >the guest arch is ppc64. Also qemu driver will assign the default >'reg' for spapr-vio address type when building the qemu command line >(if reg is not specified). So it doesn't need to specify >the spapr-vio address type explicitly if I'm right. And thus I >can't see any inconvenience. :-) > In fact, for pseries guest, scsi controller based on pci bus can also work, which can't use ibmvscsi model. In this condition, it needs to specify the controller model and pci bus address in XML file. For virt-manager, to make it work correctly, we need to specify the model and address type in the controller configuration. So I think it is inconvenient. This patch adds the VSCSI bus type and VSCSI controller type. And then the default model will be selected according to the controller type. And then disk can find the right controller to work without specifying the model and address type explicitly. In a word, some times, there should be two kinds of SCSI controllers with different address type and model on pseries. Just using the default model 'ibmvscsi' can't make it work correctly.