On 07/07/10 - 01:01:45PM, Daniel P. Berrange wrote:
diff --git a/tests/qemuargv2xmltest.c b/tests/qemuargv2xmltest.c index bd81018..501bc75 100644 --- a/tests/qemuargv2xmltest.c +++ b/tests/qemuargv2xmltest.c @@ -228,6 +228,11 @@ mymain(int argc, char **argv) DO_TEST_FULL("restore-v2", QEMUD_CMD_FLAG_MIGRATE_QEMU_EXEC, "exec:cat"); DO_TEST_FULL("migrate", QEMUD_CMD_FLAG_MIGRATE_QEMU_TCP, "tcp:10.0.0.1:5000");
+ /* it's not really possible to handle the environment variables in a + * generic way, so we run the qemu namespace test without them + */ + DO_TEST("qemu-ns-no-env", 0); +
Not sure I really understand this comment ?
Hmpf. I tried to get environment variable parsing to work when I first implemented these tests, and I know that I ran into some kind of trouble having to do with converting command-line environment variables to XML. But I can't for the life of me remember what the problem was (which also implies that my comment above is pretty much useless :). I'll have to go back and try it again; I think for the short-term we can probably commit this minus the comment, and then once I figure out the problem either implement a fix or come up with some solid reason why it isn't possible. -- Chris Lalancette