Re: [libvirt] [PATCH] qemu: ensure default machine types don't change if QEMU changes

On Tue, 2018-08-07 at 13:22 +0100, Daniel P. Berrangé wrote:

[...] > + * Our preferred pmachine might have been compiled out of s/pmachine/machine/ > + * QEMU at build time though, so we still fallback to honouring > + * QEMU's reported default in that case > + */ > + if (preferredIdx == -1) > + preferredIdx = defIdx; > + if (preferredIdx != -1) > + virQEMUCapsSetDefaultMachine(qemuCaps, preferredIdx); This is certainly an improvement compared to the current situation, so Reviewed-by: Andrea Bolognani <abologna(a)redhat.com&gt; I wonder if we shouldn't just drop the default machine type handling altogether at this point, though.