NB, please try to keep the commit message first lin at 72 chars or less, and then have a blank line, before writing the rest of the commit message. I'll fix this one up when pushing. On Tue, Sep 26, 2017 at 10:12:35AM +0800, zhenwei.pi wrote:
Signed-off-by: zhenwei.pi <zhenwei.pi@youruncloud.com> --- domain.go | 76 +++++++++++++++++++++++++++++++++++++++++++--------------- domain_test.go | 38 +++++++++++++++++++++++++++++ 2 files changed, 95 insertions(+), 19 deletions(-)
diff --git a/domain_test.go b/domain_test.go index 3ff1dc1..51d413b 100644 --- a/domain_test.go +++ b/domain_test.go @@ -435,6 +435,33 @@ var domainTestData = []struct { Value: 16384, Slots: 2, },
+ MemorySource: &DomainMemorySource{ + Type: "file|anonymous", + }, + MemoryAccess: &DomainMemoryAccess{ + Mode: "shared|private", + }, + MemoryAllocation: &DomainMemoryAllocation{ + Mode: "immediate|ondemand", + },
In these examples, you should pick either 'file' or 'anonymous', not include them both. Likewise for the access & allocation data. I'll fix this when pushing Reviewed-by: Daniel P. Berrange <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|