On 4/30/19 12:20 PM, Andrea Bolognani wrote:
On Wed, 2019-04-17 at 10:57 -0400, Cole Robinson wrote: [...]
+ virDomainDefParserConfig config = { + .features = VIR_DOMAIN_DEF_FEATURE_MEMORY_HOTPLUG | + VIR_DOMAIN_DEF_FEATURE_OFFLINE_VCPUPIN | + VIR_DOMAIN_DEF_FEATURE_INDIVIDUAL_VCPUS | + VIR_DOMAIN_DEF_FEATURE_USER_ALIAS | + VIR_DOMAIN_DEF_FEATURE_FW_AUTOSELECT | + VIR_DOMAIN_DEF_FEATURE_NET_MODEL_STRING, + };
virDomainDefParserConfig instances in other drivers usually follow the (vir)${DRIVER}DomainDefParserConfig, so I would do the same here and call it something like testDomainDefParserConfig.
Sorry I forgot to make this change before pushing...
Either way,
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
and safe for freeze.
Thanks, I've pushed it now
The second patch in the series is not as urgent, nor is it as obviously correct, so I'll probably look at it once 5.3.0 is out.
Cool. No rush on that one, it's minor - Cole