Re: [libvirt] [PATCH v2 00/17] Drop support for QEMU < 0.12.0

On 11/09/2015 11:24 AM, Daniel P. Berrange wrote: > A v2 of this series: > > https://www.redhat.com/archives/libvir-list/2015-November/msg00165.html > > The patches for introducing virtlogd will be significantly > simplified if we don't need to worry about parsing stderr > during startup. This is required prior to QEMU 0.11 so > that we can get the dyanamically allocated /dev/pty/NNN > paths. > > The QEMU 0.12.1 release was shipped in RHEL-6 vintage > distros and is already quite old, so seems like a fair > target version to aim for as the minimum required. > > By dropping support for anything older than QEMU 0.12.0 > we can remove the code for parsing stderr. The QEMU 0.12.0 > release was quite special because it was the release where > QEMU switched what I call its "modern" approach to configuration > via -device. A major part of the complexity of the QEMU command > line generator is due to need to support non-device syntax, > so by mandating QEMU 0.12.0 we'll be able to kill off alot > of conditional code. This series makes a start by assuming > existance of 5 features, -vnc, 'info chardev', -no-reboot, > -drive and -name, but there are a tonne more we can assume. > > This series drops 20 QEMU_CAPS_* flags, but there are still > another ~15-20 that can be dropped, now we assume 0.12.0 > or better. > > Changed in v2: > > - Fixed misc coverity reports from John > - Rebased to use test .args files with new line wrapping for clarity > - Split out some fixes into separate patches > - Dropped a bunch more capabilities > > Daniel P. Berrange (17): > qemu: mandate QEMU version 0.12.0 or newer > qemu: remove all support for kQEMU > qemu: assume -vnc arg always takes a ':' > qemu: assume 'info chardev' is always available > qemu: assume -no-reboot is always available > qemu: handle USB bus in qemuAssignDeviceDiskAliasFixed() > qemu: handle floppy disk bus when parsing command line argv > qemu: assume -drive argument is always available > qemu: assume -name is always available > qemu: assume -uuid is always available > qemu: really remove last traces of Xenner support > qemu: assume vnet-hdr feature is always available > qemu: assume support for all migration protocols except rdma > qemu: assume -drive cache always uses v2 option names > qemu: assume -drive format is always available > qemu: assume -vga is always available > qemu: assume various QEMU 0.10 features are always available > Other than a few things - I think the series looks good. Hopefully we'll have very few backport fix issues to a certain platform to worry about ;-). I think the one unanswered question/issue is whether we make this 1.3.0 or not. Whether any of the .spec files need adjustment is something I'm never quite sure about either...