Re: [libvirt] [PATCH 23/23] Make usbFreeDevice accept a NULL device

On 2012年12月01日 04:26, Daniel P. Berrange wrote:

From: "Daniel P. Berrange"<berrange@redhat.com>

Common practice is to accept NULL for all "free" methods

Signed-off-by: Daniel P. Berrange<berrange@redhat.com> --- src/util/hostusb.c | 3 +++ 1 file changed, 3 insertions(+)

diff --git a/src/util/hostusb.c b/src/util/hostusb.c index 24f925b..79b04eb 100644 --- a/src/util/hostusb.c +++ b/src/util/hostusb.c @@ -355,6 +355,9 @@ usbGetDevice(unsigned int bus, void usbFreeDevice(usbDevice *dev) { + if (!dev) + return; + VIR_DEBUG("%s %s: freeing", dev->id, dev->name); VIR_FREE(dev->path); VIR_FREE(dev);

ACK