Re: [libvirt] [PATCH v7] qemu: Introduce state_lock_timeout toqemu.conf
On Thu, Sep 13, 2018 at 18:47:55 +0800, Yi Wang wrote:
> When doing some job holding state lock for a long time,
> we may come across error:
>
> "Timed out during operation: cannot acquire state change lock"
>
> Well, sometimes it's not a problem and users want to continue
> to wait, and this patch allow users decide how long time they
> can wait the state lock.
[1]
> #
> #max_queued = 0
>
> +
> +# It is strongly recommended to not touch this setting
A statement like this seems like a strong indication that such a setting
should not even exist in a user-configurable way. Also the [1] commit
message justification does not inspire much confidence that it's needed.
The statement has been discussed and changed for many times, this time is
modified as this thread suggested:
https://www.redhat.com/archives/libvir-list/2018-September/msg00477.html
Well, it seemed that this patch does not intrigue many maintainers' interest,
but in some condition it is really useful and convenient, and I suppose this
is the most simplest way to achieve this at present.
Of course if this is not suitable to let this patch into upstream, I will not
continue to update it :)
Thanks to everyone again.
---
Best wishes
Yi Wang