Re: [libvirt] [PATCH 1 of 4] [LXC] Detect support for NETNS in lxc driver initialization
On Tue, Jun 24, 2008 at 08:51:33AM -0700, Dan Smith wrote:
Allow check for containers support to be done without CLONE_NEWNET,
and then
determine support on the fly by checking for iproute2 support and a
successful clone(CLONE_NEWNET). This lets us set a flag for later, as well
as not completely disable LXC support on a system without NETNS support.
Honnestly this looks fine to me, I see that Daniel has arguments about
the detection method, I would just prefer to have it dynamic as this patch
implement than something static relying on configure or RPM dependancies.
The goal to me is to try to provide best services on various installations,
since lxc and the associated kernel and net command will take a while to be
fully deployed, I prefer something very flexible at this point, even if
it may occasionally lead to a failure in some corner cases. The goal is
really to get as much people in a situation to use features the earliest
possible,
+1
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/