On a Tuesday in 2020, Peter Krempa wrote:
The 'commandhelper' checks effectively whether the parent
process is
still around to report whether it was daemonized or not.
This creates a unlikely race condition in cases when we do actually
daemonize the process as the intermediate process used for the
daemonization might not have terminated yet which would report wrong
result leading to test failure.
For now there's just 'test4' which actually daemonizes the process.
Add an argument '--check-daemonize' which asks for retires of the
:%s/retires/retries/g
daemonization check in cases where we expect that the commandhelper
is
going to be daemonized and use it in 'test4' to make the test more
reliable.
I've observed the test failure sporradically when my box is more loaded
:%s/sporradically/sporadically/g
( justone r, like the islands
https://en.wikipedia.org/wiki/Sporades )
Also:
:%s/more loaded/under load/g
or
:%s/more loaded/under heavy load/g
e.g. while building two trees at once.
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
tests/commanddata/test4.log | 1 +
tests/commandhelper.c | 17 ++++++++++++++++-
tests/commandtest.c | 3 ++-
3 files changed, 19 insertions(+), 2 deletions(-)
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Thank you for fixing this.
Jano