Re: [PATCH 2/4] tests/unit/test-char: Fix qemu_socket(), make_udp_socket() check

On Sat, Feb 03, 2024 at 09:02:26AM +0100, Markus Armbruster wrote:

qemu_socket() and make_udp_socket() return a file descriptor on success, -1 on failure. The check misinterprets 0 as failure. Fix that.

Signed-off-by: Markus Armbruster <armbru@redhat.com> --- tests/unit/test-char.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com> Might be worth amending the commit message of 1/4 where you called out this bug to mention it will be fixed in the next patch. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org