Re: [libvirt] [PATCH 1/1][RESEND] Set legacy USB option with default for ppc64.
On Sun, Apr 07, 2013 at 05:00:06PM +0800, Li Zhang wrote:
On 2013年03月14日 14:54, Li Zhang wrote:
>From: Li Zhang <zhlcindy(a)linux.vnet.ibm.com>
>
>Currently, -device xxx still can't work well for ppc64 platform.
>It's better use legacy USB option with default for ppc64.
>
>This patch is to legacy USB option with default for ppc64.
>
>Signed-off-by: Li Zhang <zhlcindy(a)linux.vnet.ibm.com>
>---
> src/qemu/qemu_command.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
>index 1c9bfc9..618dfb1 100644
>--- a/src/qemu/qemu_command.c
>+++ b/src/qemu/qemu_command.c
>@@ -5783,7 +5783,8 @@ qemuBuildCommandLine(virConnectPtr conn,
> }
> } else if (cont->type == VIR_DOMAIN_CONTROLLER_TYPE_USB
&&
> cont->model == -1 &&
>- !virQEMUCapsGet(qemuCaps, QEMU_CAPS_PIIX3_USB_UHCI)) {
>+ (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_PIIX3_USB_UHCI) ||
>+ def->os.arch == VIR_ARCH_PPC64)) {
I think you ought to modify qemu_capabilities.c to clear the
QEMU_CAPS_PIIX3_USB_UHCI flag when arch == ppc, instead of
trying to modify every place which checks that cap.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|