Re: [libvirt] [PATCH] virsh: Allow using domain and capabilities XMLs with cpu-compare
On 09/15/2011 03:40 AM, Peter Krempa wrote:
This patch adds extraction of the<cpu> element from
capabilities and
domain definition XML documents to improve user experience.
https://bugzilla.redhat.com/show_bug.cgi?id=731151
---
tools/virsh.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++--------
1 files changed, 46 insertions(+), 8 deletions(-)
@@ -11856,37 +11862,69 @@ cmdCPUCompare(vshControl *ctl, const vshCmd
*cmd)
if (vshCommandOptString(cmd, "file",&from)<= 0)
return false;
- if (virFileReadAll(from, VIRSH_MAX_XML_FILE,&buffer)< 0)
+ if (virFileReadAll(from, VIRSH_MAX_XML_FILE,&buffer)< 0) {
+ vshError(ctl, _("Failed to read file '%s' to compare."),
Generally we don't use trailing . in error messages.
ACK with that nit fixed.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org