Oops, forgot the list...
---------- Forwarded message ----------
From: Anton Protopopov <aspsk2@gmail.com>
Date: 21.02.2008 21:25
Subject: Re: [Libvir] [PATCH] Useless statement in openvzGetVPSInfo
To: veillard@redhat.com
I think, that if
pnext = &vm;
and
*pnext = calloc(...);
then
vm = calloc(...);
Isn't it?
2008/2/21, Daniel Veillard <veillard@redhat.com>:
On Thu, Feb 21, 2008 at 08:59:01PM +0300, Anton Protopopov wrote:
>
> Hi,
> the patch is now in attachement..
> I think, that the statement
> if (!vm)
> vm = *pnext;
> will never be executed: in the first pass, we have already check this
> a few lines before; in next passes, vm remains the same...
> Anton
Hum, that doesn't match what I see. vm is initialized to NULL on entry
and no changed before the loop, so on first iteration of the loop vm is
set using that code.
I don't understand the logic of your patch,
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/