Re: [libvirt] [PATCH python] Fix comparisons between signed & unsigned integers
On Tue, Sep 26, 2017 at 11:16:05AM +0100, Daniel P. Berrange wrote:
When python3 builds C modules, it adds the -Wsign-compare flag to
GCC.
This creates lots of warnings where we compare a 'size_t' value against
an 'int' value due to signed/unsigned difference. Change all the size_t
types to ssize_t to address this.
Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
Hm, I wanted this to be the case when we started to force using size_t for i,j,k
variables, but looks like I was the only one who wanted ssize_t (plus we would
be able to do that only in some places, so automatic enforcement without
-Wsign-compare would not be easily possible)
ACK
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)