Re: [libvirt] [PATCH 1/3] use virReportOOMError, not VIR_ERR_NO_MEMORY

On Tue, Jan 27, 2009 at 04:59:20PM +0100, Jim Meyering wrote: > Here's the big one: > > >From 099536470ae2cbe9503ed471d391e403fb2587a4 Mon Sep 17 00:00:00 2001 > From: Jim Meyering <meyering(a)redhat.com&gt; > Date: Tue, 27 Jan 2009 12:20:06 +0100 > Subject: [PATCH 1/3] error-reporting calls using VIR_ERR_NO_MEMORY: use virReportOOMError instead > > * src/uml_conf.c (VIR_FROM_THIS): Define to VIR_FROM_UML. > * src/xs_internal.c (VIR_FROM_THIS): Define to VIR_FROM_XEN. > * src/xml.c (VIR_FROM_THIS): Define to VIR_FROM_XML. > * src/stats_linux.c (VIR_FROM_THIS): Define to VIR_FROM_STATS_LINUX. > * src/datatypes.c (VIR_FROM_THIS): Define to VIR_FROM_NONE. > * src/lxc_conf.c (VIR_FROM_THIS): Define to VIR_FROM_LXC. > * src/libvirt.c (VIR_FROM_THIS): Define to VIR_FROM_NONE. > * src/node_device_conf.c (VIR_FROM_THIS): Define to VIR_FROM_NODEDEV. > * src/openvz_conf.c (VIR_FROM_THIS): Define to VIR_FROM_OPENVZ. > * src/openvz_driver.c (VIR_FROM_THIS): Define to VIR_FROM_OPENVZ. > * src/conf.c (VIR_FROM_THIS): Define to VIR_FROM_CONF. > Note: this loses config_filename:config_lineno diagnostics, > but that's ok. > * src/node_device.c (VIR_FROM_THIS): Define to VIR_FROM_NODEDEV. > * src/sexpr.c (VIR_FROM_THIS): Define to VIR_FROM_SEXPR. ACK. After a quick run through the patch I don't see any problems hiding there - well at least none which weren't already present.

I see this is "PATCH 1/3", but you've not sent a #2 or #3 in this series to the list ?!?!

We should add a Makefile.maint rule to prohibit use of VIR_ERR_NO_MEMORY in any file except virterror.c