Re: [libvirt] [PATCH] Miscellaneous for-loop syntax clean-ups
On Tue, Feb 23, 2016 at 12:52:38PM +0100, Ján Tomko wrote:
On Mon, Feb 22, 2016 at 11:29:54AM +0100, Martin Kletzander wrote:
> Checking whether x > 0 before looping over [0..x] items doesn't make
> sense and multi-line body must have curly brackets around it.
Please don't mix cosmetic and functional changes.
Jan
None of the changes were functional in this case, so I think it's quite
fine on this particular occasion.
> Best viewed with '-w'.
>
> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
> ---
> src/conf/domain_conf.c | 24 +++++++++++++-------
> src/qemu/qemu_capabilities.c | 30 ++++++++++++------------
> src/storage/storage_backend_rbd.c | 48 +++++++++++++++++++--------------------
> src/vbox/vbox_common.c | 14 ++++--------
> 4 files changed, 58 insertions(+), 58 deletions(-)
>
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)