Re: [libvirt] [PATCH] Don't ship autogen.sh in release tarballs
On Thu, Apr 13, 2017 at 10:11:50AM -0500, Eric Blake wrote:
On 04/13/2017 10:06 AM, Andrea Bolognani wrote:
> autogen.sh is only useful for developers, not users, and we
> expect developers to have a git checkout handy, so there's
> no point in shipping the script in release tarballs.
I'm worried this breaks the GPL. autogen.sh is our preferred way for
rebuilding autotools in preparation for a release, and thus I think the
script belongs in a tarball even if it is not expected to be used by the
end user.
Aside from the licensing question, IMHO, the tar.xz should always contain
all the files we have in GIT, plus whatever auto-generated files we decide
are needed. If nothing else that gives users clear visibility into what
generated the auto-generated files, even if they don't need to re-run that
auto-generation process themselves.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|