[Libvir] Re: [PATCH 3/7] Add option to pass stdin fd to virExec
On Mon, Aug 13, 2007 at 06:01:42AM -0400, Daniel Veillard wrote:
On Sun, Aug 12, 2007 at 07:11:35PM -0400, Jim Paris wrote:
> If nonzero, uses the supplied fd instead of /dev/null.
> Update callers accordingly.
Looks fine to me, we already have stdout and stderr, it's sensible. +1
Looks OK, but shouldn't we use -1 as the magic value here, since 0 is also
a valid file descriptor.
Regards,
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|