Re: [libvirt] [PATCH v2 0/3]usb devices with same vendorID, productID hotplug support
On 2012年05月01日 16:16, Guannan Ren wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=815755
The set of patch tries to fix the issue when multiple usb devices with
same idVendor, idProduct are availible on host, the usb device with
lowest bus:device will be attached to guest if usb xml file is given like
this:
<hostdev mode='subsystem' type='usb' managed='yes'>
<source>
<vendor id='0x15e1'/>
<product id='0x2007'/>
</source>
</hostdev>
The reason is that the usb hotplug function searchs usb device in system files
to match vendor and product id, the file with lowest number is always found
first.
After fix, in this case, libvirt will report an error as follows:
At the same time, the usb part of domain initilization is also update in patch 2/3
# virsh attach-device rhel6u1 /tmp/usb.xml
error: Failed to attach device from /tmp/usb.xml
error: XML error: multiple USB deivces 15e1:2007, use<address> to specify one.
The error could be more clear, e.g.
multiple USB deivces for vendor='15e1',
product='2007', use <address> to specify one.
And it's not "XML error", the XML is just fine. The XML with
only 'vendor' and 'product' specified could still work well
if no mulitple devices with the same vendor and product.
Perhaps VIR_ERR_INTERNAL_ERROR is a good choice.
Regards,
Osier