On Mon, Jul 18, 2022 at 04:03:15PM +0200, Michal Privoznik wrote:
Currently, we require glib-2.56.0 at minimum (because of RHEL-8) but we use G_GNUC_NO_INLINE which was introduced in 2.58.0. While we provide an implementation for older versions, where the macro does not exists, it's a bit more tricky than that. Since we define GLIB_VERSION_MAX_ALLOWED we would get a compile time error when trying to use something too new, except for G_GNUC_NO_INLINE which was intentionally not marked as GLIB_AVAILABLE_MACRO_IN_2_58. But this is about to change with glib-2.73.2 (which contains commit [1]).
At the same time, we can't just bump glib and thus we have to provide an alternative implementation without the version annotation.
1: https://gitlab.gnome.org/GNOME/glib/-/commit/a6f8fe071e44b0145619c21f3bfbc90... Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/internal.h | 12 ------------ src/util/glibcompat.h | 9 +++++++++ 2 files changed, 9 insertions(+), 12 deletions(-)
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>