Re: [libvirt-ci PATCH 07/13] lcitool: Drop the get_flavor() method
On Tue, 2020-04-28 at 10:20 +0200, Erik Skultety wrote:
On Tue, Apr 28, 2020 at 09:34:54AM +0200, Andrea Bolognani wrote:
> There are also two uses of get_flavor() remaining after this
> patch:
>
> get_gitlab_runner_token_file()
> get_gitlab_url_file()
Yeah, does it matter since I'm dropping those 2 patches later?
In the grand scheme of things? No, not really :) But removing all
calls to a function when you remove the function itself is just the
right thing to do.
--
Andrea Bolognani / Red Hat / Virtualization