Re: [libvirt] [PATCH 3/6] qemu: capabilities: Move logic deciding whether to probe into probing functions

29 Mar 2019


      On Fri, Mar 29, 2019 at 01:26:31PM +0100, Peter Krempa wrote:
...
Most probing functions in virQEMUCapsInitQMPMonitor decide internally if
there's anything to do and return success if there isn't. Move the
decision logic for virQEMUCapsProbeQMPGICCapabilities,
virQEMUCapsProbeQMPSEVCapabilities, and virQEMUCapsProbeQMPSchemaCapabilities
into the function itself so that virQEMUCapsInitQMPMonitor looks tidy.
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
You might want to split the adjustments into 3 patches, your call.

Reviewed-by: Erik Skultety <eskultet@redhat.com>