On Thu, Sep 05, 2013 at 02:21:53PM +0200, Peter Krempa wrote:
On 09/05/13 13:03, Daniel P. Berrange wrote:
On Wed, Sep 04, 2013 at 10:58:23AM +0800, Gao feng wrote:
Generate debug message when systemd doesn't support interface org.freedesktop.machine1.Manager.
Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com> --- src/util/virsystemd.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c index 3e69ef6..c631557 100644 --- a/src/util/virsystemd.c +++ b/src/util/virsystemd.c @@ -233,6 +233,7 @@ int virSystemdCreateMachine(const char *name, if (err->code == VIR_ERR_DBUS_SERVICE && STREQ(err->str2, "org.freedesktop.DBus.Error.ServiceUnknown")) { virResetLastError(); + VIR_DEBUG("systemd doesn't support interface org.freedesktop.machine1.Manager");
Is this really needed ? The virRaiseError call will have already reported this scenario surely ?
Yes, it will. It is actually spamming the log with "error" messages every time you start a VM on a non-systemd host even when it is later successful using the old approach.
We likely need to invoke org.freedesktop.DBus.ListActivatableNames and/or org.freedesktop.DBus.NameHasOwner to find out if systemd is available without triggering an error. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|