Re: [libvirt] [PATCH] schema: fix idmap validation

On Fri, Jan 10, 2014 at 10:42:35AM -0700, Eric Blake wrote: > When idmap was added to LXC, we forgot to cover it in the testsuite. > The schema was missing an <element> layer, and as a result, > virt-xml-validate was failing on valid dumpxml output. > > Reported by Eduard - Gabriel Munteanu on IRC. > > * docs/schemas/domaincommon.rng (idmap): Include <idmap> element, > and support interleaves. > * tests/lxcxml2xmldata/lxc-idmap.xml: New file. > * tests/lxcxml2xmltest.c (mymain): Test it. > > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; > --- > > Eduard, please confirm I spelled your name correctly.

> > docs/schemas/domaincommon.rng | 58 +++++++++++++++++++++----------------- > tests/lxcxml2xmldata/lxc-idmap.xml | 38 +++++++++++++++++++++++++ > tests/lxcxml2xmltest.c | 1 + > 3 files changed, 71 insertions(+), 26 deletions(-) > create mode 100644 tests/lxcxml2xmldata/lxc-idmap.xml ACK