Re: [libvirt] [PATCH] unlock the monitor when unwatching the monitor

On Wed, Mar 16, 2011 at 02:54:28PM +0800, Wen Congyang wrote: > Steps to reproduce this bug: > # virsh qemu-monitor-command domain 'cpu_set 2 online' --hmp > The domain has 2 cpus, and we try to set the third cpu online. > The qemu crashes, and this command will hang. > > The reason is that the refs is not 1 when we unwatch the monitor. > We lock the monitor, but we do not unlock it. So virCondWait() > will be blocked. >

> qemuMonitorLock(mon); > - qemuMonitorUnref(mon); > + if (qemuMonitorUnref(mon) > 0) > + qemuMonitorUnlock(mon); > } ACK

We should probably annotate qemuMonitorUnref() (and similar functions) with ATTRIBUTE_RETURN_CHECK too