Re: [libvirt] [PATCH 06/11] Remove abuse of networkPrivateData in phyp driver

On 10/23/2014 09:14 AM, Daniel P. Berrange wrote:

For inexplicable reasons the phyp driver defined two separate structs for holding its private data. One it keeps in privateData and the other it keeps in networkPrivateData. It uses them both from all API driver methods. Merge the two separate structs into one to remove this horrible abuse. --- src/phyp/phyp_driver.c | 190 +++++++++++++++++-------------------------------- 1 file changed, 66 insertions(+), 124 deletions(-)

ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org