On 09/12/2013 07:37 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
The VIR_ACCESS_PERM_CONNECT_DETECT_STORAGE_POOLS enum constant had its string format be 'detect_storage_pool', note the missing trailing 's'. This prevent the ACL check from ever succeeding. Fix this and add a simple test script to validate this problem of matching names.
+foreach my $perm (keys %perms) { + print STDERR "Perm $perm had not string form\n";
You've already pushed, but I just now noticed this sounds awkward. Maybe "Perm $perm was missing a string form\n"? On the other hand, since this message only ever occurs to a developer adding a new permission, where the developer's bug would be fixed before it is actually committed to libvirt.git, I'm not going to be bothered if we leave it alone. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org