Re: [libvirt] [PATCH v1 2/4] remote: Implement remote{Get,Set}Time
On 02/14/2014 06:23 AM, Martin Kletzander wrote:
On Thu, Feb 13, 2014 at 07:51:43PM +0100, Michal Privoznik wrote:
> This is also adding new ACL permission to check 'set_time'.
>
> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
> ---
Applies to previous patch too, this 'time' will be a problem with
'-Wshadow-declarations' on older (some) compilers.
ACK with that variable name changed.
I'm half-tempted to just tweak m4/virt-compile-warnings.m4 to drop
-Wshadow-declarations on older gcc. Since newer gcc is sane about local
variables not conflicting with public functions, it's not worth worrying
about the collisions that only older gcc reports.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)