Re: [libvirt] [PATCH 07/10] Support virDomainOpenConsole with QEMU

On 11/01/2010 10:12 AM, Daniel P. Berrange wrote: > This provides an implementation of the virDomainOpenConsole > API with the QEMU driver. For the streams code, this reuses > most of the code previously added for the tunnelled migration > streams since it is generic. > > * src/qemu/qemu_driver.c: Support virDomainOpenConsole > --- > src/qemu/qemu_driver.c | 76 +++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 75 insertions(+), 1 deletions(-) > > + if (devname) { > + if (vm->def->console && > + STREQ(devname, vm->def->console->info.alias)) > + chr = vm->def->console; > + for (i = 0 ; !chr && i < vm->def->nserials ; i++) { > + if (STREQ(devname, vm->def->serials[i]->info.alias)) > + chr = vm->def->serials[i]; > + } Are we guaranteed that all devices will have a non-NULL and unique alias, or do we need to do either of these: