Re: [libvirt] [PATCH 2/9] conf: Extract code filling data for virDomainGetVcpuPinInfo

On 02/24/2016 09:22 AM, Peter Krempa wrote: > The implementation of the inner guts of the function is similar for all > drivers, so we can add a helper and not have to reimplement it three > times. > --- > src/conf/domain_conf.c | 64 ++++++++++++++++++++++++++++++++++++++++++++++++ > src/conf/domain_conf.h | 8 ++++++ > src/libvirt_private.syms | 1 + > src/libxl/libxl_driver.c | 38 +++------------------------- > src/qemu/qemu_driver.c | 43 +++----------------------------- > src/test/test_driver.c | 38 ++++------------------------ > 6 files changed, 84 insertions(+), 108 deletions(-) > ACK with one nit... One difference I noted, the 'libxl' code would: memset(cpumaps, 0x00, maplen * ncpumaps); just before filling. Should that be replicated in the common code? If not then for the libxl code should the lines be kept?