19 May
2014
19 May
'14
5:26 p.m.
Eric Blake wrote:
BTW, that's going to be a vast change, quick grep shows more than 750 calls of that function.
It doesn't invalidate any existing caller to make virObjectUnlock() special-case NULL. And while it DOES make any existing caller that also checks for NULL be a case of redundant code, we don't have to clean all callers up in a single patch.
Good, so I'll add a check for NULL in virObjectUnlock() and prepare a series that cleans up the redundant if (obj) check before calling virObjectUnlock(obj), say, on per-driver basis. Roman Bogorodskiy