Re: [libvirt] [PATCH 0/5]: Rework iSCSI lun handling
Chris Lalancette schreef:
Stefan de Konink wrote:
> Chris Lalancette schreef:
>> 4) Further lessen our dependence on direct calls to iscsiadm, in case they
>> change the output in the future.
> How are you looking against this previous proposed setup where we will
> give an updated Makefile to the open-iscsi folks (to build
> libopen-iscsi.so) and implement an specific open-iscsi iscsi driver that
> uses the exact same functions as open-iscsi does itself?
Yeah, it's not a bad plan at all. Someone just needs to work with upstream
open-iscsi tools to split their stuff out into a library. I'm totally for this
type of implementation; not only will we not have to fork and exec for some of
this stuff, we should be able to get better error messages as well.
The I have looked at there Makefile before, and build this. They already
mark there 'libraries'. So it would be only one update...
That being said, until this sort of change makes it upstream, we have
to work
with what we've got at the moment.
True, but also: it will only work with new versions of open-iscsi, so
the sooner we get the 'fix/enhancement' the more chance our new
implementation will have.
Stefan