Re: [libvirt] [libvirt-glib 1/2] Use g_strlcpy instead of strncpy

On 12/14/2012 05:03 PM, Christophe Fergeau wrote: > This guarantees that the string will be nul-terminated. Coverity > warned about this issue. > --- > libvirt-gobject/libvirt-gobject-connection.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libvirt-gobject/libvirt-gobject-connection.c b/libvirt-gobject/libvirt-gobject-connection.c > index 91cc535..0525323 100644 > --- a/libvirt-gobject/libvirt-gobject-connection.c > +++ b/libvirt-gobject/libvirt-gobject-connection.c > @@ -1583,7 +1583,7 @@ GVirNodeInfo *gvir_connection_get_node_info(GVirConnection *conn, > } > > ret = g_slice_new(GVirNodeInfo); > - strncpy (ret->model, info.model, sizeof (ret->model)); > + g_strlcpy (ret->model, info.model, sizeof (ret->model)); > ret->memory = info.memory; > ret->cpus = info.cpus; > ret->mhz = info.mhz; > OK, so nobody's having a look at this, so if I have the rights... ACK,