Re: [libvirt] [RFC] Add flag for virsh undefine to remove/wipe the disk devices

On Wed, Mar 30, 2011 at 09:50:19PM +0800, Daniel Veillard wrote: > On Wed, Mar 30, 2011 at 09:39:14PM +0800, Osier Yang wrote: > > For these situations, we need to do checking and throw > > straightforward warnings to tell user why it can't be > > removed/wiped. > > I would rather make this a flag of virDomainUndefine(), except > there is no flag argument for it :( I don't think this is a good idea. Applications should directly call the storage APIs for this, so that when we adding RBAC support to our APIs, we get correct access control checks on *each* volume being deleted / wiped. We won't want the 'undefine' API for a VM to be side-stepping the volume access controls.