Re: [libvirt] [PATCH v4 1/7] bridge_driver: Don't access global driver randomly

On Thu, Mar 12, 2015 at 15:39:15 +0100, Michal Privoznik wrote:

Well, network driver code has the driver accessible as a global variable. This makes any rework hard, as it's unclear where the variable is accessed and/or modified. Lets just pass the driver as a parameter to all functions where needed.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/network/bridge_driver.c | 430 +++++++++++++++++++++++++------------------- 1 file changed, 247 insertions(+), 183 deletions(-)

ACK, the renaming to network driver made it really easy to review. Peter